fix castException with byte[] #965
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the Viewer there is a CastException in the Byte[] in some WAVE files
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## integration #965 +/- ##
=================================================
+ Coverage 47.04% 47.29% +0.25%
- Complexity 1103 1111 +8
=================================================
Files 57 57
Lines 9087 8990 -97
Branches 1625 1622 -3
=================================================
- Hits 4275 4252 -23
+ Misses 4280 4211 -69
+ Partials 532 527 -5 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
carlwilson
approved these changes
Sep 20, 2024
There was a problem hiding this comment.
I see the problem and that looks a straightforward fix. Thanks @samalloing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @carlwilson
In the Viewer there is a CastException in the Byte[] in some WAVE files
This fixes #926
Sam